Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenCTI Connector Charms #3

Merged
merged 99 commits into from
Jan 24, 2025
Merged

Add OpenCTI Connector Charms #3

merged 99 commits into from
Jan 24, 2025

Conversation

weiiwang01
Copy link
Collaborator

Overview

Add the framework for OpenCTI connector charms, including a charm library that serves as the foundation for all OpenCTI connector charms and a template for generating OpenCTI connector charm projects.

This pull request also introduces 18 connector charms.

Crowdstrike
Sekoia
VirusTotal
AbuseIPDB
MISP Feed
MalwareBazaar Recent Additions
CISA Know Exploited Vulnerabilities
urlscan.io
Cyber Campaign Collection
URLHaus
AlienVault
VX Vault
Mitre ATT&CK
Import Document
Import File STIX
Export File CSV
Export File STIX
Export File TXT

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@weiiwang01
add opencti rock
07170cf
@weiiwang01
Add basic charm
11dbfc8
@weiiwang01
Fix linting issues
4f210cf
@weiiwang01
Update config description
1dbcebf
@weiiwang01
Fix linting issues
a948dcb
@weiiwang01
Fix linting issues
e990cd3
@weiiwang01
Fix linting issues
3632067
@weiiwang01
Fix linting issues
22077d2
@weiiwang01
Fix tests
676b9a0
@weiiwang01
Add license headers
dc9ce01
@weiiwang01
Update runner
d1c0c05
@weiiwang01
Improved start-up callback
38db050
@weiiwang01
Use github hosted runners
8a1264b
@weiiwang01
Update rockcraft.yaml
0caebdc
@weiiwang01
Debug
020665a
@weiiwang01
Remove unnecessary files
336b84c
@weiiwang01
Remove unnecessary files
702add8
@weiiwang01
Fix charm.py
1f2b5c5
@weiiwang01
Remove debug info
403aa75
@weiiwang01
Stop callback in callback itself
4dbc03a
@weiiwang01
clean up requirements.txt
e494868
@weiiwang01
Update documents
875e116
@weiiwang01
Update unit tests
9387460
@weiiwang01
Apply suggestions from review comments
61e7daa
@weiiwang01
work in progress
89e1c49
@weiiwang01
work in progress
c13a476
@weiiwang01
work in progress
e5c0518
@weiiwang01
Apply suggestions from review comments
ab0eb50
@weiiwang01
Merge platform/graphql and platform/graphql-deps in rockcraft.yaml
88ae9c1
@weiiwang01
Add missing stage-snaps and stage-packages
a781a43
jdkandersson
jdkandersson reviewed Jan 21, 2025
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
jdkandersson
jdkandersson reviewed Jan 23, 2025
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
jdkandersson
jdkandersson previously approved these changes Jan 24, 2025
View reviewed changes
Copy link

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together! It is good to go from my side

gregory-schiano
gregory-schiano previously approved these changes Jan 24, 2025
View reviewed changes
Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks :)

@github-actions GitHub Actions
Copy link
Contributor

Test coverage for 020e8ce

Name             Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------
src/charm.py       311     31     76     11    87%   132, 207-219, 237-238, 455-456, 543-549, 667, 671, 676, 691, 693->689, 697, 715, 720->724, 725, 734-736
src/opencti.py      59     32     10      0    39%   61-69, 83-125, 143-171, 186-202, 215-231
------------------------------------------------------------
TOTAL              370     63     86     11    79%

Static code analysis report

Run started:2025-01-24 08:59:27.709720

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 868
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit 7a77cfa into main Jan 24, 2025
93 checks passed
@weiiwang01 weiiwang01 deleted the connectors branch January 24, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhaliaw yhaliaw yhaliaw left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@gregory-schiano gregory-schiano gregory-schiano approved these changes

@jdkandersson jdkandersson jdkandersson approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiiwang01 @yhaliaw @jdkandersson @gregory-schiano